Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All test in floor_generator run now #808

Merged
merged 19 commits into from
Mar 13, 2024

Conversation

hendrikvdkaaden
Copy link
Contributor

The command flutter test did not work. To fix this, I updated all the dependencies. After doing this, some problems arose in the fakes.dart and string_extension.dart files, which I also fixed. Additionally, I corrected some tests that were not accurate. To run the tests, you need to use flutter pub run test.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (feature/dep_update@84adcdf). Click here to learn what that means.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             feature/dep_update     #808   +/-   ##
=====================================================
  Coverage                      ?   91.92%           
=====================================================
  Files                         ?       11           
  Lines                         ?      223           
  Branches                      ?        0           
=====================================================
  Hits                          ?      205           
  Misses                        ?       18           
  Partials                      ?        0           
Flag Coverage Δ
floor 91.92% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dkaera dkaera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work
left a few comments to find out what benefits these changes bring

floor_generator/test/fakes.dart Outdated Show resolved Hide resolved
floor_generator/test/fakes.dart Outdated Show resolved Hide resolved
floor_generator/test/fakes.dart Outdated Show resolved Hide resolved
floor_generator/test/fakes.dart Outdated Show resolved Hide resolved
@hendrikvdkaaden hendrikvdkaaden changed the base branch from develop to feature/dep_update March 8, 2024 10:49
@hendrikvdkaaden hendrikvdkaaden changed the base branch from feature/dep_update to develop March 8, 2024 10:57
@hendrikvdkaaden hendrikvdkaaden requested a review from dkaera March 13, 2024 11:28
Copy link
Collaborator

@dkaera dkaera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thank you for contributing 🚀

@hendrikvdkaaden hendrikvdkaaden changed the base branch from develop to feature/dep_update March 13, 2024 12:44
# Conflicts:
#	.github/workflows/ci.yml
#	floor/pubspec.lock
#	floor/pubspec.yaml
#	floor_generator/pubspec.lock
#	floor_generator/pubspec.yaml
@hendrikvdkaaden hendrikvdkaaden merged commit 3069255 into feature/dep_update Mar 13, 2024
8 checks passed
@hendrikvdkaaden hendrikvdkaaden deleted the feature/running_test_fix branch March 13, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants